Merged
Conversation
don't need to pass schema/table if they are determined by the target action.
labkey-jeckels
approved these changes
Oct 10, 2025
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
I like making the actions more self-sufficient in terms of the initialization. Also consider breaking out the actual new QueryForm() call from the other initialization that's duplicated across overrides. Note that I didn't do any manual testing.
Contributor
|
@labkey-matthewb please add this to one of the team boards so we give it a quick visit during standup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We don't need to pass schema/table if they are determined by the target action.
Issue 54072
Related Pull Requests
Changes